Message handler: add quote_begin, quote_end commands #5696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
allredj,
chrisr-diffblue,
hannes-steffenhagen-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli,
romainbrenguier and
smowton
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5696 +/- ##
===========================================
- Coverage 80.39% 80.38% -0.02%
===========================================
Files 1688 1688
Lines 207403 207485 +82
Branches 73 73
===========================================
+ Hits 166749 166781 +32
- Misses 40654 40704 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tautschnig
force-pushed
the
quote-command
branch
3 times, most recently
from
32acae2 to
3604763
Compare
martin-cs
approved these changes
Jan 11, 2021
Collaborator
martin-cs
left a comment
martin-cs
left a comment
There was a problem hiding this comment.
Seems good. It would be nice if this also had the implementation of this for XML so that it was clear why it was valueable and no-one will accidentally 'simplify' it out.
src/util/ui_message.h
Outdated
| case 96: // bright_cyan | ||
| return std::string(); | ||
| case '<': // quote_begin | ||
| return "<quote>"; |
Member
There was a problem hiding this comment.
Not sure this is a good idea as it changes the XML output format. I'd stick to single quotes for now and introduce a different format in a separate PR if desired.
Collaborator
Author
There was a problem hiding this comment.
I have now factored this into a commit of its own, which could thus easily be dropped from the series.
Member
There was a problem hiding this comment.
I would really prefer to drop this commit. IMO, it causes unnecessary hassle to XML output users.
Collaborator
Author
There was a problem hiding this comment.
Removed, just left behind a comment that this could be done.
tautschnig
force-pushed
the
quote-command
branch
from
402b16a to
e423424
Compare
tautschnig
requested review from
NlightNFotis,
TGWDB,
chris-ryder and
thomasspriggs
as code owners
tautschnig
force-pushed
the
quote-command
branch
from
e423424 to
3bcd0c6
Compare
tautschnig
force-pushed
the
quote-command
branch
from
3bcd0c6 to
99e7c06
Compare
tautschnig
force-pushed
the
quote-command
branch
from
99e7c06 to
5b56934
Compare
peterschrammel
approved these changes
Oct 27, 2022
TGWDB
approved these changes
Oct 27, 2022
tautschnig
force-pushed
the
quote-command
branch
from
5b56934 to
4429ed9
Compare
tautschnig
force-pushed
the
quote-command
branch
from
4429ed9 to
90be428
Compare
tautschnig
force-pushed
the
quote-command
branch
from
90be428 to
ff0b549
Compare
tautschnig
force-pushed
the
quote-command
branch
from
ff0b549 to
de2a0c5
Compare
tautschnig
force-pushed
the
quote-command
branch
from
de2a0c5 to
01e7746
Compare
TGWDB
approved these changes
Feb 24, 2023
tautschnig
force-pushed
the
quote-command
branch
from
4dcfcd6 to
fcacae2
Compare
These will permit custom formatting of quoting for each message handler, See diffblue#4875 for discussion.
This continues the work of diffblue#4875, but now using quote_begin/quote_end stream modifiers.
This is in the spirit of diffblue#4875, but now using quote_begin/quote_end stream modifiers.
tautschnig
force-pushed
the
quote-command
branch
from
fcacae2 to
476ebc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will permit custom formatting of quoting for each message handler, and for a start introduce tags for XML. See #4875 for discussion.
Please review commit-by-commit.